Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to remove producers section #1256

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

alexcrichton
Copy link
Contributor

This should help handle instances like the recent Webpack bug and is
also a useful flag in its own right. For now it's set to false, but if
the Webpack bug persists through to tomorrow we likely want to publish a
version of wasm-bindgen with it default set to true.

This should help handle instances like the recent Webpack bug and is
also a useful flag in its own right. For now it's set to `false`, but if
the Webpack bug persists through to tomorrow we likely want to publish a
version of `wasm-bindgen` with it default set to `true`.
@xtuc
Copy link
Member

xtuc commented Feb 14, 2019

Thanks for the quick fix! And sorry for the delay.

I think that you can go ahead and merge it, I believe the Webpack folks are busy at a conf.

@fitzgen
Copy link
Member

fitzgen commented Feb 14, 2019

Looks like we are still hitting the bug?

https://travis-ci.com/rustwasm/wasm-bindgen/jobs/177863766#L873-L889

Error: Unexpected section: 0xfe
    at new CompileError (/home/travis/build/rustwasm/wasm-bindgen/node_modules/@webassemblyjs/helper-api-error/lib/index.js:40:109)
    at parseSection (/home/travis/build/rustwasm/wasm-bindgen/node_modules/@webassemblyjs/wasm-parser/lib/decoder.js:1542:11)
    at Object.decode (/home/travis/build/rustwasm/wasm-bindgen/node_modules/@webassemblyjs/wasm-parser/lib/decoder.js:1559:25)
    at decode (/home/travis/build/rustwasm/wasm-bindgen/node_modules/@webassemblyjs/wasm-parser/lib/index.js:240:21)
    at WebAssemblyParser.parse (/home/travis/build/rustwasm/wasm-bindgen/node_modules/webpack/lib/wasm/WebAssemblyParser.js:74:19)
    at doBuild.err (/home/travis/build/rustwasm/wasm-bindgen/node_modules/webpack/lib/NormalModule.js:460:32)
    at runLoaders (/home/travis/build/rustwasm/wasm-bindgen/node_modules/webpack/lib/NormalModule.js:342:12)
    at /home/travis/build/rustwasm/wasm-bindgen/node_modules/loader-runner/lib/LoaderRunner.js:373:3
    at iterateNormalLoaders (/home/travis/build/rustwasm/wasm-bindgen/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
    at Array.<anonymous> (/home/travis/build/rustwasm/wasm-bindgen/node_modules/loader-runner/lib/LoaderRunner.js:205:4)
    at Storage.finished (/home/travis/build/rustwasm/wasm-bindgen/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:43:16)
    at provider (/home/travis/build/rustwasm/wasm-bindgen/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:79:9)
    at /home/travis/build/rustwasm/wasm-bindgen/node_modules/graceful-fs/graceful-fs.js:90:16
    at FSReqWrap.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:53:3)
 @ ./pkg/add.js 2:0-33 10:11-19
 @ ./index.js

@fitzgen
Copy link
Member

fitzgen commented Feb 14, 2019

Ah, looks like CI wasn't updated to use this flag for the examples. Want to do that to verify the work around?

@alexcrichton
Copy link
Contributor Author

Oh FWIW this isn't switching the defaults it's just adding an option. I figured we'd give Webpack a bit to release a new version as it just got fixed today. If it persists though I figured we'd temporarily change the defaults.

@alexcrichton alexcrichton merged commit c57e2b0 into rustwasm:master Feb 15, 2019
@alexcrichton alexcrichton deleted the remove-producers branch February 15, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants