Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for importing default exports #1106

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

mvlabat
Copy link
Contributor

@mvlabat mvlabat commented Dec 11, 2018

This should fix #1006

This PR doesn't mangle reserved JS words, only default. This is an alternative to #1091

@mvlabat
Copy link
Contributor Author

mvlabat commented Dec 11, 2018

O_o. For some reason failure crate fails to build. Can't reproduce it locally... Is it some kind of CI bug?

@alexcrichton alexcrichton merged commit c6b74ff into rustwasm:master Dec 11, 2018
@alexcrichton
Copy link
Contributor

No worries that was my own mistake!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using #[wasm_bindgen(constructor)] for a module that is a type
2 participants