Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to remove the wasm name section #1024

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

alexcrichton
Copy link
Contributor

This commit adds a --remove-name-section flag to the wasm-bindgen
command which will remove the name section of the wasm file, used to
indicate the names of functions typically used in debugging. This flag
is off-by-default and will primarily be controlled by wasm-pack,
typically being passed by default with wasm-pack build --release.

Closes #1021

This commit adds a `--remove-name-section` flag to the `wasm-bindgen`
command which will remove the `name` section of the wasm file, used to
indicate the names of functions typically used in debugging. This flag
is off-by-default and will primarily be controlled by wasm-pack,
typically being passed by default with `wasm-pack build --release`.

Closes rustwasm#1021
Copy link
Member

@sendilkumarn sendilkumarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍. But I think adding a test would be great here

@alexcrichton
Copy link
Contributor Author

Unfortunately we don't have many tests for wasm-bindgen's CLI today, but this'll get tested soon through wasm-pack so I'm gonna go ahead and merge

@alexcrichton alexcrichton merged commit 406581d into rustwasm:master Nov 9, 2018
@alexcrichton alexcrichton deleted the remove-names branch November 9, 2018 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants