Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a clippy job in CI #267

Closed
wants to merge 33 commits into from
Closed

chore: add a clippy job in CI #267

wants to merge 33 commits into from

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Jul 2, 2024

Description

Applied clippy suggestions.

Also bumped the dev-dependencies to the latest major versions.

gimli

Now the only not yet updated dependency in Cargo.toml is gimli.
When trying to upgrade it, I got an deprecation warning about Dwarf::borrow and it requires more work to get rid of this warning message.
Also gimli::read::Dwarf is in the public API of walrus, upgrading major version of gimli is a breaking change.

pub struct ModuleDebugData {
    pub dwarf: read::Dwarf<Vec<u8>>,
}

Since we just released version 0.21.0, I believe it's not the best time to introduce a small change that would necessitate another major release soon.

@lwshang lwshang marked this pull request as ready for review July 2, 2024 21:00
@guybedford
Copy link
Collaborator

While this is not a BytecodeAlliance project specifically, BA projects as a general rule don't take clippy PRs or CI jobs.

That said I would be happy to apply improvements, but without anything that specifically calls out clippy or clippy conventions (ie the CI job and the clippy attribute).

@guybedford
Copy link
Collaborator

Since we just released version 0.21.0, I believe it's not the best time to introduce a small change that would necessitate another major release soon.

If you would like to look at the Gimli upgrade here, posting an immediate 0.22.0 would be fine by me actually, especially given that 0.21.0 has been out for not very long.

@lwshang
Copy link
Contributor Author

lwshang commented Jul 3, 2024

I see. I will make another PR which only upgrade dependencies and fix deprecation warnings.

@lwshang lwshang closed this Jul 3, 2024
@lwshang lwshang deleted the clippy branch July 3, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants