Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denial of service with debug build of http-codec #59

Closed
wants to merge 1 commit into from

Conversation

niklasf
Copy link
Contributor

@niklasf niklasf commented Sep 7, 2018

This is mostly a case of

When in doubt, please open a PR.

It's a minor issue, because only debug builds and builds with -C overflow-checks=on are affected. One reason to file an advisory would be that this is unlikely to get fixed: I contacted the author and he says he is no longer maintaining the crate.

@tarcieri
Copy link
Member

Hi there, sorry for the delay reviewing this.

It sounds like a panic for debug builds and integer overflow for non-debug builds. Either way that does not seem good. I think this is worth including.

@Shnatsel
Copy link
Member

As per the criteria discussed here I'd rather not include otherwise harmless overflows and debug-mode panics, at least until a severity system is in place.

@tarcieri
Copy link
Member

Alright, I can agree with that

@tarcieri tarcieri closed this Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants