-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(diff): show diff statistics #1178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I would only request small changes:
- maybe name "file changed" into "content changed"
- and either add more detailed "change types" for the other changes which are currently collected under "file changed"
- or add a single "other changes" to collect all those other changes.
@nardoor Sorry for the late review. About tests, in rustic we only have integration tests (and very few) so you could try to generate some testdata in a tar-files (or just one tar and modify files by hand), run the command and check the output (maybe using the insta crate). But this is pretty complicated as these tests may be OS-specific. In rustic we are not that strict requesting unit tests, so far. |
Hello @aawsome, Thanks for taking the time to review the proposed changes. About tests, I might try to add an integration test about this feature, but if I get stuck on some OS specifics as you warned me, I might leave it (for later?). |
first draft at addressing rustic-rs#440
with new types added:
|
e7115fe
to
1cf41c0
Compare
d7a40e6
to
62ea247
Compare
62ea247
to
5099ed1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks again @nardoor
I removed the unused "use" statement.
Thanks for finishing the work and looking at my PR! |
closes #440
Description
The proposed code contains:
diff
functionExemple
Testing
I am not sure what tests I can add.
Please let me know if you think of any test about this.
Thanks in advance for any feedback.