Discover NIFs at startup #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proof-of-concept for a mechanism that does away with the need to list all NIF functions in the `rustler::init!` invocation. A similar mechanism will be required and implemented for resource type registrations. - Convert `Nif` to a `struct` - Use `inventory` to register the `Nif` instances - In `rustler::init!`, ignore the passed functions and instead use the registered `Nif` instances Next steps: - See whether `linkme` is not a better option (creates the array directly at build-time, no need to leak) - Implement resource registration using this mechanism - See if we can move the macros to `rustler`
|
Love this idea! |
scrogson
reviewed
Jun 5, 2024
scrogson
reviewed
Jun 5, 2024
The behaviour to be tested had been moved to the other NIF in the same module without removing the unused function.
|
From my point of view, this is done and ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept for a mechanism that does away with the need to list all NIF functions in the
rustler::init!invocation. A similar mechanism will be required and implemented for resource type registrations.Nifto astructinventoryto register theNifinstancesrustler::init!, ignore the passed functions and instead use the registeredNifinstancesNext steps:
linkmeis not a better option (creates the array directly at build-time, no need to leak) (/edit Looking at this again, don't think this adds much, the current implementation is fine)rustler(might do this in another iteration, no need to put it in the same PR)