Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - Add positions to mouse click events. #1289

Closed
wants to merge 1 commit into from
Closed

WIP - Add positions to mouse click events. #1289

wants to merge 1 commit into from

Conversation

icefoxen
Copy link
Contributor

@icefoxen icefoxen commented Nov 26, 2019 •
edited
Loading

For the sake of argument. And catharsis. Addresses issue #883 for some platforms, so I can see how much work it actually takes. Not implemented for macos 'cause I don't have a way to test it.

  • Tested on all platforms changed -- Haven't tested on Windows yet.
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@icefoxen
Add positions to mouse click events.
5213d1f 
For the sake of argument.  And catharsis.
ryanisaacg
ryanisaacg approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@ryanisaacg ryanisaacg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only speak for the web platform, but I wouldn't be opposed to this. It maps to the browser input model cleanly and solves a fairly large user papercut.

@chelmich
Copy link
Contributor

Tested on Windows 10. Works as intended.

@M-Adoo
Copy link

M-Adoo commented Jun 16, 2020

Any progress on this?

@daxpedda
Copy link
Member

daxpedda commented Jun 2, 2023

I will close this as it's unmaintained and needs a serious rebase after #2662.
Would be happy to review a renewal!

Continues to be tracked in #883.

@daxpedda daxpedda closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanisaacg ryanisaacg ryanisaacg approved these changes

Assignees
No one assigned
Labels
C - in progress Implementation is proceeding smoothly DS - macos DS - wayland DS - web DS - windows DS - x11
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@icefoxen @chelmich @M-Adoo @daxpedda @ryanisaacg @goddessfreya