Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No character getting received on international keyboard on macOS. #1208

Closed
kchibisov opened this issue Oct 4, 2019 · 2 comments
Closed

No character getting received on international keyboard on macOS. #1208

kchibisov opened this issue Oct 4, 2019 · 2 comments
Labels
B - bug Dang, that shouldn't have happened C - needs investigation Issue must be confirmed and researched DS - macos

Comments

@kchibisov
Copy link
Member

kchibisov commented Oct 4, 2019 •
edited
Loading

It was reported to Alacritty that when pressing Control + Shift + 7 on Norwegian keyboard no characters are getting received. For the reference this keyboard has / on Shift + 7, so it assumed that it should act like Shift + Control + 7 on us keyboard (I mean it should gets / like it gets& when on us). Shift + 7 works just fine on this keyboard (sends / and getting Slash virtual_keycode).

alacritty bug for the reference alacritty/alacritty#2850
@goddessfreya goddessfreya added DS - macos C - needs investigation Issue must be confirmed and researched B - bug Dang, that shouldn't have happened labels Oct 18, 2019
@goddessfreya
Copy link
Contributor

Related: #812 #753

@DorianRudolph
Copy link

DorianRudolph commented Aug 9, 2020 •
edited
Loading

This also happens in Linux/Wayland. I need to manually set the keybinding Control+Shift+7.

@maroider maroider mentioned this issue Dec 20, 2020
Closed
@afh afh mentioned this issue Oct 6, 2021
Closed
kchibisov added a commit that referenced this issue May 28, 2023
@maroider @ArturKovacs
@kchibisov @daxpedda
Overhaul the Keyboard API
a870147 
Overhaul the keyboard API in winit to mimic the W3C specification
to achieve better crossplatform parity. The `KeyboardInput` event
is now uses `KeyEvent` which consists of:

  - `physical_key` - a cross platform way to refer to scancodes;
  - `logical_key`  - keysym value, which shows your key respecting the
                     layout;
  - `text`         - the text produced by this keypress;
  - `location`     - the location of the key on the keyboard;
  - `repeat`       - whether the key was produced by the repeat.

And also a `platform_specific` field which encapsulates extra
information on desktop platforms, like key without modifiers
and text with all modifiers.

The `Modifiers` were also slightly reworked as in, the information
whether the left or right modifier is pressed is now also exposed
on platforms where it could be queried reliably. The support was
also added for the web and orbital platforms finishing the API
change.

This change made the `OptionAsAlt` API on macOS redundant thus it
was removed all together.

Co-Authored-By: Artúr Kovács <kovacs.artur.barnabas@gmail.com>
Co-Authored-By: Kirill Chibisov <contact@kchibisov.com>
Co-Authored-By: daxpedda <daxpedda@gmail.com>
Fixes: #2631.
Fixes: #2055.
Fixes: #2032.
Fixes: #1904.
Fixes: #1810.
Fixes: #1700.
Fixes: #1443.
Fixes: #1343.
Fixes: #1208.
Fixes: #1151.
Fixes: #812.
Fixes: #600.
Fixes: #361.
Fixes: #343.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B - bug Dang, that shouldn't have happened C - needs investigation Issue must be confirmed and researched DS - macos
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DorianRudolph @goddessfreya @kchibisov