docs: Improve documentation for safe window handles #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
commented
Mar 20, 2023
Comment on lines
+40
to
+44
| /// The `Active` struct works around this by providing a borrow-checker enforced guarantee that the | ||
| /// application is not suspended. This takes advantage of the fact that he current callback-based event | ||
| /// loop setup for [`winit`], [`sdl2`] and other event loop systems to my knowledge requires an | ||
| /// `&mut self` reference to the event loop. This means that it is not possible to borrow the event loop | ||
| /// and poll for events at the same. |
There was a problem hiding this comment.
Hmm, realized this may not work with Window implementing HasDisplayHandle. Might need to rethink either implementing HasDisplayHandle on Window, or something different...
There was a problem hiding this comment.
doesn't the display that the window shows up within have the actual display?
|
Superseded by #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves documentation for the new types and traits in the
borrowed.rsfile.I did some research into Android lifecycles, so I'm pretty sure now that the
Activetrick works and why it does. I also add notes on window ID invalidation to the window handle part.cc #111