-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: move get_proc_address
to GlDisplay
#1460
api: move get_proc_address
to GlDisplay
#1460
Conversation
Thanks! That was a blocker for #1417 to function in a clean way :) |
Uhm, there's still a problem with WGL, I think we have nothing better than document that... |
This should made it clear that you should call this only once and not on each context creation.
8b3688e
to
ca96b59
Compare
I've added a comment wrt that, since having function on the context is missleading in the first place, because you'll try to load it each time you create the context. |
Yeah you mentioned in #1417 but it's probably worth mentioning it explicitly in the PR here too to investigate. Can you add an optional current context argument to |
Co-authored-by: Marijn Suijten <marijns95@gmail.com>
The thing is that it'll still load, it will be just a limited set of functions. You won't have shaders, but you'll have I'll see whether it'll raise issues and adjust if folks will struggle with that. |
I did not know that. Then indeed, I agree that we shouldn't crash, documenting this properly is all we can do. Let's see if any issues arise. |
This should made it clear that you should call this only once and not on each context creation.
CHANGELOG.md
if knowledge of this change could be valuable to users