vsock: try epoll_modify before epoll_register in recv_pkt #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikicha
requested review from
mathieupoirier,
stsquad,
vireshk and
stefano-garzarella
as code owners
|
@ikicha this breaks the existing tests which makes me think this isn't the right approach. |
stsquad
reviewed
Oct 27, 2023
ikicha
force-pushed
the
large_pkt_drop
branch
2 times, most recently
from
aa37219
to
f8c4a0b
Compare
ikicha
force-pushed
the
large_pkt_drop
branch
from
f8c4a0b
to
13940d4
Compare
ikicha
force-pushed
the
large_pkt_drop
branch
from
13940d4
to
99597c3
Compare
ikicha
changed the title
in this context, epoll listener can be already registered via other TX event, so let it try epoll_modify first to avoid 'silent' failure which possibly drops packets. Signed-off-by: Jeongik Cha <jeongik@google.com>
like recv_pkt, added log for epoll_register error instead of panic Signed-off-by: Jeongik Cha <jeongik@google.com>
ikicha
force-pushed
the
large_pkt_drop
branch
from
2e2d111
to
6de2ec6
Compare
stefano-garzarella
approved these changes
Oct 31, 2023
vireshk
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
The problem: vhost-device vsock failed to send "large" packet from guest to host
How to fix: in this context, epoll listener can be already registered via other TX event, so let it try epoll_modify first to avoid 'silent' failure which possibly drops packets.
Fixes #494
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.