Allow controlling of the maximum queue size for daemons #202
Labels
Comments
|
@stsquad Do you have the patch that fixes it ? |
|
I think they just hardcoded it for the purposes of the demo. |
dorjoy03
added a commit
to dorjoy03/vhost-device
that referenced
this issue
Jul 8, 2024
The vring queue size was hardcoded to 256 which is problematic for vsock devices that use a larger queue size. For example, when using vhost-device-vsock with QEMU's vhost-user-vsock-device, the message to set the vring queue size to 1024 causes an "InvalidParameter" error from vhost-device-vsock. Making the queue size configurable via an option makes it easy to use vhost-device-vsock where a larger queue size is required. The default queue size has also been increased to 1024. Fixes: rust-vmm#202 Signed-off-by: Dorjoy Chowdhury <dorjoychy111@gmail.com>
dorjoy03
added a commit
to dorjoy03/vhost-device
that referenced
this issue
Jul 8, 2024
The vring queue size was hardcoded to 256 which is problematic for vsock devices that use a larger queue size. For example, when using vhost-device-vsock with QEMU's vhost-user-vsock-device, the message to set the vring queue size to 1024 causes an "InvalidParameter" error from vhost-device-vsock. Making the queue size configurable via an option makes it easy to use vhost-device-vsock where a larger queue size is required. The default queue size has also been increased to 1024. Fixes: rust-vmm#202 Signed-off-by: Dorjoy Chowdhury <dorjoychy111@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This came up with the Gunyah integration testing with CrosVM. As their implementation has a fairly small amount of memory in the shared memory portion they couldn't fit the QUEUE_SIZE queue in it. This was solved with a local patch for the demo but obviously it would be nice to control this via an option/config.
The text was updated successfully, but these errors were encountered: