Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is and has support #187

Merged
merged 1 commit into from
Jul 22, 2024
Merged

is and has support #187

merged 1 commit into from
Jul 22, 2024

Conversation

cfvescovo
Copy link
Member

Closes #169

@cfvescovo
Copy link
Member Author

@adamreichold You mentioned you have a diverse set of scrapers a while ago so I was wondering if you could test this

@adamreichold
Copy link
Member

@adamreichold You mentioned you have a diverse set of scrapers a while ago so I was wondering if you could test this

Yes, gladly. It might take a few days until I get this into our staging environment for one of our overnight runs and the results back here, but I will give it a spin.

@adamreichold
Copy link
Member

I has seen one overnight run and I have not seen any error rate increases. I'll give it another round and browse the logs a bit tomorrow...

@adamreichold
Copy link
Member

adamreichold commented Jul 20, 2024

Sorry for not coming back earlier, but things did not go as planned. We now have unexplained hangs. I do think this is actually tokio-rs/tokio#6682 but I will have to bump dependencies and wait for runs (without hangs) to be sure.

@cfvescovo
Copy link
Member Author

Sorry for now coming back earlier, but things did not go as planned. We now have unexplained hangs. I do think this is actually tokio-rs/tokio#6682 but I will have to bump dependencies and wait for runs (without hangs) to be sure.

Maybe you could retry using this Tokio branch instead of the latest release or main

@cfvescovo
Copy link
Member Author

nvm, they should have fixed it in 1.38.1

@adamreichold
Copy link
Member

Yes, I have redeployed using this branch and Tokio 1.38.1 (instead of 1.38.0). First run was successful, but funnily enough daily and nightly runs do not appear comparable as the servers we are scraping appear to produce more timeouts/retries over night due various maintenance processes...

Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So after deploying Tokio 1.38.1, this have been going smoothly and I think this branch was never at fault. So this good to go from my side.

@cfvescovo cfvescovo merged commit 27dd786 into master Jul 22, 2024
5 checks passed
@LoZack19 LoZack19 deleted the support-has-selector branch August 26, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for :has() selector
2 participants