Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another try at actually using an nth index cache #164

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Another try at actually using an nth index cache #164

merged 1 commit into from
Dec 26, 2023

Conversation

adamreichold
Copy link
Member

This re-uses the cache only between the match operations for a single select iteration which ensures that the selector is not dropped (and its allocation address re-used) while the cache is alive thereby avoiding the ABA problem fixed by 7fdac0a.

This does not require any change in user code to benefit from the increased caching even though some Debug and Clone implementations need to be done manually now.

This re-uses the cache only between the match operations for a single select
iteration which ensures that the selector is not dropped (and its allocation
address re-used) while the cache is alive thereby avoiding the ABA problem fixed
by 7fdac0a.

This does not require any change in user code to benefit from the increased
caching even though some Debug and Clone implementations need to be done
manually now.
@cfvescovo cfvescovo merged commit 1f89042 into rust-scraper:master Dec 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants