Configurable kernel stack size, better non-x86_64 errors #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Nice cleanup in the build.rs. CI is currently broken because of rust-lang/rust#63195. Since this is a non-critical change I would probably wait a day or two until the issue is fixed instead of force-merging. |
|
I think the rust nightly should be fixed now. bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 5, 2019
72: Configurable kernel stack size, better non-x86_64 errors r=phil-opp a=64 Allows the configuration of the kernel stack size through an environment variable. Also makes the errors a bit nicer if you try to use this crate from a non-x86_64 architecture (only works if you build it as a library), as discussed in #70. Co-authored-by: Matt Taylor <mstaveleytaylor@gmail.com>
Build failed
|
|
@64 Could you cargo fmt this? |
|
Damn, I really need to set up a pre-commit hook or something... |
bors bot
added a commit
that referenced
this pull request
Aug 5, 2019
72: Configurable kernel stack size, better non-x86_64 errors r=phil-opp a=64 Allows the configuration of the kernel stack size through an environment variable. Also makes the errors a bit nicer if you try to use this crate from a non-x86_64 architecture (only works if you build it as a library), as discussed in #70. Co-authored-by: Matt Taylor <mstaveleytaylor@gmail.com>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the configuration of the kernel stack size through an environment variable.
Also makes the errors a bit nicer if you try to use this crate from a non-x86_64 architecture (only works if you build it as a library), as discussed in #70.