Reserve 3 frames for higher half kernels #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'm currently looking into this issue too and I think there might be a better way to solve this. I'll keep you posted. |
|
All good! Thanks! |
|
For reference the limine bootloader subtracts the fixed higher half offset from the elf header section. |
|
Closing as of #161 |
|
I opened #161 with an alternative fix.
I'm not sure why this is done, maybe because the bootloader is still in 32 bit mode at this point? In our case, we are already in 64 bit mode when doing the mapping, so we can create mappings across the whole virtual address space without problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reserves three frames instead of two for higher half kernel support.
Related: #159