Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "panic message is not a string literal" #138

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

dspencer12
Copy link
Contributor

@dspencer12 dspencer12 commented Feb 24, 2021

Updates build.rs to use the second form of the assert! macro, which can take a format string and arguments, without needing to use format!.

This should resolve #137.

Updates build.rs to use the second form of the assert! macro, which can
take a format string and arguments, without needing to use format!.
@phil-opp
Copy link
Member

Thank you!

The Windows/macOS CI is currently broken because of a bug in QEMU, but this change shouldn't break anything.

@phil-opp phil-opp merged commit a35cda4 into rust-osdev:main Feb 24, 2021
phil-opp added a commit that referenced this pull request Feb 24, 2021
@phil-opp
Copy link
Member

Published as v0.9.13.

@dspencer12
Copy link
Contributor Author

It looks like v0.9.13 doesn't actually include the change commit, just updates to the changelog and Cargo.toml.

@phil-opp
Copy link
Member

Oh dang, seems like renaming the master branch to main caused this. My local environment was still on master, which didn't include this PR since it was merged to main. Thanks a lot for reporting!

I just published v0.9.14, which should now really include this PR.

@dspencer12
Copy link
Contributor Author

Just checked and it's definitely included this time, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic message is not a string literal
2 participants