Change 1st stage int 13h addressing #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for this! Seems like I missed the fact that the buffer must be inside the same memory segment. This also means that our bootloader must not be larger than 64KiB right? The implementation looks good to me! |
phil-opp
approved these changes
Jul 16, 2020
phil-opp
added a commit
that referenced
this pull request
Jul 16, 2020
|
Published as v0.9.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the addressing of the bootloader loading from disk on stage 1, so the buffer doesn't cross the memory segment boundary, as is required by int 13h/ah=42h (see Wikipedia).
With this change the bootloader no longer gets stuck on stage 1 on VirtualBox. Also tested on QEMU and Bochs, but not on real hardware.
Feel free to rewrite in a better way as I have no previous experience with asm.