Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make builder executable available as binary? #48

Closed
timClicks opened this issue Feb 16, 2019 · 1 comment
Closed

Make builder executable available as binary? #48

timClicks opened this issue Feb 16, 2019 · 1 comment

Comments

@timClicks
Copy link

Would you consider adding the builder executable to a [[bin]] section of the cargo manifest a good idea? That should simplify things for people who don't want to clone the repo and manually cd into the builder directory to make use of it.

If so, I'm happy to whip up the short PR

@phil-opp
Copy link
Member

That's a good idea, but I'm not sure how it would work with the dependencies. The builder crate uses some dependencies that rely on the standard library, which we can't use for the rest of the bootloader. AFAIK there is currently no way to define dependencies only for a specific binary. Maybe we can work around it by (ab)using cargo's platform specific dependencies somehow.

@phil-opp phil-opp mentioned this issue Mar 23, 2019
2 tasks
bors bot added a commit that referenced this issue Apr 1, 2019
51: Rewrite build system r=phil-opp a=phil-opp

- [x] Blocked on rust-lang/rust#59351
- [x] Blocked on rust-lang/cargo#6778

Fixes #33 
Fixes #48

Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
@bors bors bot closed this as completed in #51 Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants