ndk/bitmap: Provide detailed implementation for AndroidBitmapInfoFlags
#424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Aug 22, 2023
ndk/src/bitmap.rs
Outdated
Comment on lines
155
to
159
| /// Bitfield containing information about the bitmap. | ||
| #[cfg(feature = "api-level-30")] | ||
| #[derive(Clone, Copy)] | ||
| #[repr(transparent)] | ||
| pub struct AndroidBitmapInfoFlags(u32); |
There was a problem hiding this comment.
Unsure if I should make this into a proper bitflags, there are currently only two valid values (the alpha mask, and the IS_HARDWARE flag).
MarijnS95
force-pushed
the
bitmap-info-flags
branch
3 times, most recently
from
df8a24a
to
bfa2350
Compare
As per the TODO, wrap this flags type with some helpers that fish out the two bit-representations for the `IS_HARDWARE` flag and `ALPHA` value. Also add missing documentation and aliases across the `bitmap` module.
MarijnS95
force-pushed
the
bitmap-info-flags
branch
from
bfa2350
to
6c987b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the TODO, wrap this flags type with some helpers that fish out the two bit-representations for the
IS_HARDWAREflag andALPHAvalue.Also add missing documentation and aliases across the
bitmapmodule.CC @dcsommer since you most recently touched this module and are likely relying on it: can you give this a review?