-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ndk: Rework media error types #399
Conversation
Thinking of doing the same little tweaks to |
fddda40
to
b3b7858
Compare
b3b7858
to
95220e7
Compare
LGTM! By the way, |
Yes indeed. It has bothered me too, but not enough to come up with a more restrictive cfg bound. Those are generally error-prone and would require extensive checking of all With this PR |
I'm considering at least constraining this with |
95220e7
to
2424bdf
Compare
@paxbun done, moved and fixed the cfg feature bounds. You'll have to add Though as you don't use |
Otherwise I might as well switch back to |
Yup it does :( |
- Clean up the names: we're already in the `ndk` crate so no need to repeat that in the type name; - Make the types available outside the `media` module, so that they can be used in `AMidi` bindings which are not located inside `libmediandk.so` (but `libamidi.so`); - Add documentation comments; - Guard `dead_code` helper functions with the right `feature` bound.
2424bdf
to
6f010eb
Compare
I also think guarding the whole module with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
CC @paxbun
ndk
crate so no need to repeat that in the type name;media
module, so that they can be used inAMidi
bindings which are not located insidelibmediandk.so
(butlibamidi.so
);dead_code
helper functions with the rightfeature
bound.