-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ndk-build: Support android:resizeableActivity
#338
ndk-build: Support android:resizeableActivity
#338
Conversation
android:resizeableActivity
android:resizeableActivity
Co-authored-by: Marijn Suijten <marijns95@gmail.com>
@MarijnS95 Thanks for your review. I've addressed your feedback, please have another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Incidentally, looks like users have already previously (incorrectly) assumed that this attribute was supported: |
@RagnarListig I don't fully remember if the previous implementation serialized all tables parsed from TOML into XML, which won't suffer from that. Regardless, that's what you sometimes get with external contributions 😬 |
This is a trivial pull request to add support for the
android:resizeableActivity
attribute on<activity>
, needed e.g. for manifests for the Oculus Quest VR headset.