Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

looper: Model ALOOPER_EVENT with bitflags #158

Merged
merged 1 commit into from
Jul 24, 2021

Conversation

MarijnS95
Copy link
Member

The event field/parameter cannot have more states than these few carefully defined constants, and should be exposed as a proper restricted type since it's part of the public API.

The `event` field/parameter cannot have more states than these few
carefully defined constants, and should be exposed as a proper
restricted type since it's part of the public API.
Copy link
Contributor

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MarijnS95
Copy link
Member Author

@dvc94ch Thanks!

@MarijnS95 MarijnS95 merged commit 49e8ed5 into rust-mobile:master Jul 24, 2021
@MarijnS95 MarijnS95 deleted the looper-event-bitflags branch July 24, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants