Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider setting require_optional_deps to false for standard library. #37

Closed
ehuss opened this issue Sep 6, 2019 · 1 comment · Fixed by rust-lang/cargo#7337
Closed

Consider setting require_optional_deps to false for standard library. #37

ehuss opened this issue Sep 6, 2019 · 1 comment · Fixed by rust-lang/cargo#7337
Labels
implementation Implementation exploration and tracking issues

Comments

@ehuss
Copy link
Contributor

ehuss commented Sep 6, 2019

Currently the workspace created for the standard library sets require_optional_deps to true. I'm not sure if it matters, but my instinct is that it might need to be false? Needs some investigation.
@ehuss ehuss added the implementation Implementation exploration and tracking issues label Sep 6, 2019
alexcrichton added a commit to alexcrichton/cargo that referenced this issue Sep 6, 2019
@alexcrichton
Don't resolve std's optional dependencies
4592af4 
Use the `set_require_optional_deps(false)` escape hatch to avoid
resolving optional dependencies for libstd. While it doesn't really
matter a huge amount either way there's no need for us to generate
resolution nodes for things like `rand` just to throw them away because
they're never used.

Closes rust-lang/wg-cargo-std-aware#37
@alexcrichton alexcrichton mentioned this issue Sep 6, 2019
Merged
bors added a commit to rust-lang/cargo that referenced this issue Sep 6, 2019
@bors
Auto merge of #7337 - alexcrichton:less-optional, r=ehuss
ad9e421 
Don't resolve std's optional dependencies

Use the `set_require_optional_deps(false)` escape hatch to avoid
resolving optional dependencies for libstd. While it doesn't really
matter a huge amount either way there's no need for us to generate
resolution nodes for things like `rand` just to throw them away because
they're never used.

Closes rust-lang/wg-cargo-std-aware#37
@alexcrichton
Copy link
Member

Done in rust-lang/cargo#7337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
implementation Implementation exploration and tracking issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't resolve std's optional dependencies alexcrichton/cargo
2 participants
@ehuss @alexcrichton