Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BTreeMap::new_in should be const #118

Closed
Kritzefitz opened this issue Oct 8, 2023 · 2 comments · Fixed by rust-lang/rust#116559
Closed

BTreeMap::new_in should be const #118

Kritzefitz opened this issue Oct 8, 2023 · 2 comments · Fixed by rust-lang/rust#116559

Comments

@Kritzefitz
Copy link

The title basically already says it all. alloc::collections::btree_map::BTreeMap::new_in is currently not marked as const, even though there doesn't seem to be a good reason why it shouldn't be.
@Amanieu
Copy link
Member

Amanieu commented Oct 8, 2023

Sounds good! Feel free to submit a PR and assign it to me for review.

Kritzefitz added a commit to Kritzefitz/rust that referenced this issue Oct 9, 2023
@Kritzefitz
Make BTreeMap::new_in const
bbc2304 
Closes rust-lang/wg-allocators#118
@Kritzefitz Kritzefitz mentioned this issue Oct 9, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 10, 2023
@matthiaskrgr
Rollup merge of rust-lang#116559 - Kritzefitz:btree-new-in-const, r=A…
42dcf77 
…manieu

Mark `new_in` as `const` for BTree collections

Discussed in and closes rust-lang/wg-allocators#118
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Oct 10, 2023
@GuillaumeGomez
Rollup merge of rust-lang#116559 - Kritzefitz:btree-new-in-const, r=A…
b72db84 
…manieu

Mark `new_in` as `const` for BTree collections

Discussed in and closes rust-lang/wg-allocators#118
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 10, 2023
@rust-timer
Unrolled build for rust-lang#116559
345eec4 
Rollup merge of rust-lang#116559 - Kritzefitz:btree-new-in-const, r=Amanieu

Mark `new_in` as `const` for BTree collections

Discussed in and closes rust-lang/wg-allocators#118
@Kritzefitz
Copy link
Author

If I'm not mistaken, the merged PR fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark new_in as const for BTree collections Kritzefitz/rust
2 participants
@Amanieu @Kritzefitz