Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #3665 #3668

Closed
wants to merge 25 commits into from
Closed

resolves #3665 #3668

wants to merge 25 commits into from

Conversation

la10736
Copy link
Contributor

@la10736 la10736 commented Jul 4, 2019 •
edited
Loading

resolves #3665

  • Implementation and test based on rustfmt::skip::macros() feature
  • Refactoring to encapsulate both macros and attributes
  • Removed useless RefCell

@la10736 la10736 changed the title Implement #3665 resolves #3665 Jul 4, 2019
scampi
scampi approved these changes Jul 13, 2019
View reviewed changes
src/attr.rs Outdated Show resolved Hide resolved
src/skip.rs Outdated Show resolved Hide resolved
src/skip.rs Show resolved Hide resolved
src/skip.rs Outdated Show resolved Hide resolved
@scampi
Copy link
Contributor

scampi commented Jul 13, 2019

can you update the changelog file ?

calebcartwright and others added 15 commits July 15, 2019 17:19
@calebcartwright
fix: handling of --all when dep name and dir name differ (#3664)
0b533e0
@topecongiro
Do not consider macro-origin await as chain item (#3671)
950e9f9
@topecongiro
Update CHANGELOG.md
d4a3694
@topecongiro
Release 1.3.2
4b28c36
@calebcartwright
feat: add --manifest-path support to cargo fmt
0978f8d
Extract configuration snippet tests into own module (#3667)
899e279 
* Extract configuration snippet tests into own module

* Move helper function outside of test function
@ehuss
Fix using --help, --verbose, etc. (#3620)
bee3946
@rchaser53
fix 'extra comma inserted due to comment' (#3677)
670c11f
@calebcartwright
refactor: simplify manifest_path option checks
b949ac2
@scampi
fix print-config minimal option (#3687)
3591a34
@topecongiro
Fix bugs related to file-lines (#3684)
4b54abd
@topecongiro
Update CHANGELOG.md
ac13dbc
@topecongiro
Release 1.3.3
bcd05bd
#3665 Clean up:
7b32170 
- better naming
- `skip` module doc
- update CHANGELOG
- removed useless `*`
@la10736
Merge branch 'master' into master
73e8ac3
@la10736
Copy link
Contributor Author

la10736 commented Jul 15, 2019

Sorry... I did some craps on rebasing my fork.... Now should be ok.

@scampi
Copy link
Contributor

scampi commented Jul 15, 2019

@la10736 there are few more commits you can drop, e.g., fix print-config minimal option. It's ok to just open a new clean PR ;o)

Michele d'Amico and others added 2 commits July 15, 2019 21:10
@la10736
#3665 Clean up:
64e82b7 
- better naming
- `skip` module doc
- update CHANGELOG
- removed useless `*`
@la10736
#3665: Clean CHANGELOG
3c5df8a
@la10736
Copy link
Contributor Author

la10736 commented Jul 15, 2019

Ok I'm closing it

@la10736 la10736 closed this Jul 15, 2019
@la10736
Copy link
Contributor Author

la10736 commented Jul 15, 2019

Ok a fresh new PR at #3689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scampi scampi scampi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip Attribute
6 participants
@la10736 @scampi @calebcartwright @topecongiro @ehuss @rchaser53