Add suport for extern types. #1946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I understand correctly this needs a new branch for rustfmt and rls, so rustc can point at them |
|
This is on the extern-type branch, and the RLS branch is rustfmt-extern-type. |
|
Thanks @nrc. I think you forgot to push to rls tough, the rustfmt-extern-type branch is currently even with master |
|
@plietar ah crap, sorry about that. Branch is now upstream. In reply to your irc question, you can either commit after updating the submodule (commit in the Rust root) or you can set submodules=false in config.toml to stop rustbuild updating the submodules at all. |
|
This PR has been merged, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#44295