Skip to content

Commit

Permalink
Clarify PR responsible for underlying improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
rylev committed Feb 25, 2021
1 parent 19a801b commit 786b6e4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion triage/2021-02-24.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Only store a LocalDefId in some HIR nodes [#81611](https://github.com/rust-lang/

Inline try_get_cached [#82197](https://github.com/rust-lang/rust/issues/82197)
- Very large improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=8fe989dd768f5dfdb0fc90933f3f74fa4579fefd&end=ee88f46bb5e27c4d9f30326e69ff2298dcbeecb1&stat=instructions:u) (up to -10.4% on `full` builds of `externs-debug`)
- An attempt to fix an issue due to a bad interaction with [#81892](https://github.com/rust-lang/rust/issues/81892) which removed a bunch of largely unnecessary inline directives.
- This change shows improvements originally expected from [#81855](https://github.com/rust-lang/rust/issues/81855), which based query fast path on try_get_cached. In-between the initial successful perf run of #81855 and merging, another PR [#81892](https://github.com/rust-lang/rust/issues/81892) removed an inline hint from the function, which was soon to be on the fast path.

Reduce size of InterpErrorInfo to 8 bytes [#82116](https://github.com/rust-lang/rust/issues/82116)
- Moderate improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=ee88f46bb5e27c4d9f30326e69ff2298dcbeecb1&end=5ef21063f0c0fd5b973bfa8cb88c0b70982da977&stat=instructions:u) (up to -4.1% on `full` builds of `ctfe-stress-4-check`)
Expand Down

0 comments on commit 786b6e4

Please sign in to comment.