Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for TyCtxt<'a, 'gcx, 'tcx> -> TyCtxt<'tcx>. #340

Merged
merged 1 commit into from
Jun 15, 2019

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Jun 14, 2019

See rust-lang/rust#61722 and rust-lang/rust#61817 for some backstory.

cc @mark-i-m @rust-lang/compiler

@@ -25,7 +25,6 @@ early-bound lifetime | a lifetime region that is substituted at its definiti
empty type | see "uninhabited type".
Fat pointer | a two word value carrying the address of some value, along with some further information necessary to put the value to use. Rust includes two kinds of "fat pointers": references to slices, and trait objects. A reference to a slice carries the starting address of the slice and its length. A trait object carries a value's address and a pointer to the trait's implementation appropriate to that value. "Fat pointers" are also known as "wide pointers", and "double pointers".
free variable | a "free variable" is one that is not bound within an expression or term; see [the background chapter for more](./background.html#free-vs-bound)
'gcx | the lifetime of the global arena ([see more](../ty.html))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description should be moved to 'tcx.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'gcx | the lifetime of the global arena ([see more](../ty.html))
'tcx | the lifetime of the allocation arena ([see more](../ty.html))

@@ -141,8 +141,7 @@ to the compiler.
- `cx` tends to be short for "context" and is often used as a suffix. For
example, `tcx` is a common name for the [Typing Context][tcx].

- [`'tcx` and `'gcx`][tcx] are used as the lifetime names for the Typing
Context.
- [`'tcx`][tcx] is used as the lifetim names for the Typing Context.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lifetim typo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [`'tcx`][tcx] is used as the lifetim names for the Typing Context.
- [`'tcx`][tcx] is used as the lifetime names for the Typing Context.

Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the changes Zoxc pointed out above.

Thanks @eddyb!

There was also some discussion about changing the name of TyCtxt to QueryCxt or something (I forget where I read that). Is that still a planned change?

@mark-i-m mark-i-m merged commit f675e36 into rust-lang:master Jun 15, 2019
@mark-i-m mark-i-m mentioned this pull request Jun 15, 2019
@eddyb eddyb deleted the begone-gcx branch June 16, 2019 07:40
@eddyb
Copy link
Member Author

eddyb commented Jun 16, 2019

@mark-i-m The QueryCx stuff is longer term, now that we got to tcx: TyCtxt<'tcx> directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants