Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document multipart_suggestion derive on SessionSubdiagnostic #1446

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

Xiretza
Copy link
Contributor

@Xiretza Xiretza commented Aug 24, 2022

@Xiretza Xiretza force-pushed the derive-multipart-suggestion branch from ce68ce6 to bd5ed63 Compare August 24, 2022 19:49
@Xiretza Xiretza marked this pull request as ready for review September 1, 2022 16:50
@Xiretza
Copy link
Contributor Author

Xiretza commented Sep 1, 2022

Waiting for rust-lang/rust#101294.

@JohnTitor JohnTitor added the blocked This PR is blocked waiting for some other PR label Sep 1, 2022
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me once rust-lang/rust#101294 lands.

@davidtwco davidtwco self-assigned this Sep 2, 2022
@davidtwco davidtwco merged commit 5be5475 into rust-lang:master Sep 5, 2022
@Xiretza Xiretza deleted the derive-multipart-suggestion branch September 6, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This PR is blocked waiting for some other PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants