Add note to emphasize replacing TARGET_TRIPLE #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
reviewed
Nov 5, 2021
src/building/suggested.md
Outdated
| @@ -45,6 +45,12 @@ you can write: <!-- date: 2021-09 --><!-- the date comment is for the edition be | |||
| in your `.vscode/settings.json` file. This will ask `rust-analyzer` to use | |||
| `x.py check` to check the sources, and the stage 0 rustfmt to format them. | |||
|
|
|||
| > NOTE: Make sure to replace `TARGET_TRIPLE` in the `rust-analyzer.rustfmt.overrideCommand` | |||
| > setting with the appropriate target triple for your machine. An example of such | |||
| > a triple is `x86_64-unknown-linux-gnu`. An easy way to check the target triple | |||
There was a problem hiding this comment.
Suggested change
| > a triple is `x86_64-unknown-linux-gnu`. An easy way to check the target triple | |
| > a triple is `x86_64-unknown-linux-gnu`. An easy way to check your target triple |
src/building/suggested.md
Outdated
Comment on lines
51
to
52
| > is looking in the `build` folder in the root of your rust clone after building the | ||
| > compiler at least once. It will have a folder with the same name as your target triple. |
There was a problem hiding this comment.
I think this is easier:
Suggested change
| > is looking in the `build` folder in the root of your rust clone after building the | |
| > compiler at least once. It will have a folder with the same name as your target triple. | |
| > is to run `rustc -vV` and check `host` of its output. |
|
Could you also pick up #1219 (comment)? |
|
I wasn't aware of that field from rustc output, that's handy! Also added the |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 10, 2021
Update books ## nomicon 1 commits in 358e6a61d5f4f0496d0a81e70cdcd25d05307342..c6b4bf831e9a40aec34f53067d20634839a6778b 2021-10-20 11:23:12 -0700 to 2021-11-09 02:30:56 +0900 - Replace some use of variant with covariant (rust-lang/nomicon#322) ## book 11 commits in fd9299792852c9a368cb236748781852f75cdac6..5c5dbc5b196c9564422b3193264f3288d2a051ce 2021-10-22 21:59:46 -0400 to 2021-11-09 19:30:43 -0500 - Fix constants link. - Fix updated anchor - Propagate edits to chapter 2 back - Edits to nostarch's chapter 3 edits - ch 3 from nostarch - Fix Cargo.toml snippet about custom derive macros - Snapshot of chapter 9 for nostarch - Create tmp/src for converting quotes, not sure why this broke but ok - Update question mark to better explain where it can be used - Clarify sentence about Results in functions that don't return Result. Fixes rust-lang/book#2912. - Merge pull request rust-lang/book#2913 from covariant/patch-1 ## rust-by-example 2 commits in 27f1ff5e440ef78828b68ab882b98e1b10d9af32..e9d45342d7a6c1def4731f1782d87ea317ba30c3 2021-10-13 08:04:40 -0300 to 2021-11-02 13:33:03 -0500 - Enums: Linked-List Needs Re-Wording (rust-lang/rust-by-example#1469) - fix: Use the point as top left corner for `square` (rust-lang/rust-by-example#1471) ## rustc-dev-guide 13 commits in b06008731af0f7d07cd0614e820c8276dfed1c18..196ef69aa68f2cef44f37566ee7db37daf00301b 2021-10-21 15:13:09 -0500 to 2021-11-07 07:48:47 -0600 - Fix typo: [upv.rs_mentioned] -> [upvars_mentioned] - Add note to emphasize replacing TARGET_TRIPLE (rust-lang/rustc-dev-guide#1250) - Remove some legacy test suites. - tiny capitalization fix - Fix date - Update some date-check comments - Ensure date-check cron job is using latest stable Rust - enhance subtree docs, link to clippy docs - Edit introduction to bootstrapping - Some minor adjustments to the diagnostic documentation - Edit "About this guide" for semantic line feeds - Fix `rustc_mir` related links (rust-lang/rustc-dev-guide#1228) - Add documentation for LLVM CFI support ## edition-guide 3 commits in 7c0088ca744d293a5f4b1e2ac378e7c23d30fe55..27f4a84d3852e9416cae5861254fa53a825c56bd 2021-10-05 13:28:05 +0200 to 2021-11-08 10:13:20 -0500 - Add a missing period (rust-lang/edition-guide#271) - Fix syntax error in code example (rust-lang/edition-guide#270) - Fixed an example error of prelude.md (rust-lang/edition-guide#269)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 10, 2021
Update books ## nomicon 1 commits in 358e6a61d5f4f0496d0a81e70cdcd25d05307342..c6b4bf831e9a40aec34f53067d20634839a6778b 2021-10-20 11:23:12 -0700 to 2021-11-09 02:30:56 +0900 - Replace some use of variant with covariant (rust-lang/nomicon#322) ## book 11 commits in fd9299792852c9a368cb236748781852f75cdac6..5c5dbc5b196c9564422b3193264f3288d2a051ce 2021-10-22 21:59:46 -0400 to 2021-11-09 19:30:43 -0500 - Fix constants link. - Fix updated anchor - Propagate edits to chapter 2 back - Edits to nostarch's chapter 3 edits - ch 3 from nostarch - Fix Cargo.toml snippet about custom derive macros - Snapshot of chapter 9 for nostarch - Create tmp/src for converting quotes, not sure why this broke but ok - Update question mark to better explain where it can be used - Clarify sentence about Results in functions that don't return Result. Fixes rust-lang/book#2912. - Merge pull request rust-lang/book#2913 from covariant/patch-1 ## rust-by-example 2 commits in 27f1ff5e440ef78828b68ab882b98e1b10d9af32..e9d45342d7a6c1def4731f1782d87ea317ba30c3 2021-10-13 08:04:40 -0300 to 2021-11-02 13:33:03 -0500 - Enums: Linked-List Needs Re-Wording (rust-lang/rust-by-example#1469) - fix: Use the point as top left corner for `square` (rust-lang/rust-by-example#1471) ## rustc-dev-guide 13 commits in b06008731af0f7d07cd0614e820c8276dfed1c18..196ef69aa68f2cef44f37566ee7db37daf00301b 2021-10-21 15:13:09 -0500 to 2021-11-07 07:48:47 -0600 - Fix typo: [upv.rs_mentioned] -> [upvars_mentioned] - Add note to emphasize replacing TARGET_TRIPLE (rust-lang/rustc-dev-guide#1250) - Remove some legacy test suites. - tiny capitalization fix - Fix date - Update some date-check comments - Ensure date-check cron job is using latest stable Rust - enhance subtree docs, link to clippy docs - Edit introduction to bootstrapping - Some minor adjustments to the diagnostic documentation - Edit "About this guide" for semantic line feeds - Fix `rustc_mir` related links (rust-lang/rustc-dev-guide#1228) - Add documentation for LLVM CFI support ## edition-guide 3 commits in 7c0088ca744d293a5f4b1e2ac378e7c23d30fe55..27f4a84d3852e9416cae5861254fa53a825c56bd 2021-10-05 13:28:05 +0200 to 2021-11-08 10:13:20 -0500 - Add a missing period (rust-lang/edition-guide#271) - Fix syntax error in code example (rust-lang/edition-guide#270) - Fixed an example error of prelude.md (rust-lang/edition-guide#269)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the suggested workflows page there is an example settings.json file that many people use. It uses a placeholder
TARGET_TRIPLEin the file name, but many people, myself included on one occasion, forget to replace it or don't notice that it needs replacing. This adds an emphasized note that should help remind people that replacing the triple is necessary.Closes #1219