Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift clippy::for_loops_over_fallibles lint into rustc #99696

Merged
merged 19 commits into from
Oct 10, 2022
Merged

Uplift clippy::for_loops_over_fallibles lint into rustc #99696

merged 19 commits into from
Oct 10, 2022

Commits on Oct 9, 2022

  1. Start uplifting clippy::for_loops_over_fallibles 

    I refactored the code:
- Removed handling of methods, as it felt entirely unnecessary
- Removed clippy utils (obviously...)
- Used some shiny compiler features
  (let-else is very handy for lints 👀)
- I also renamed the lint to `for_loop_over_fallibles` (note: no `s`).
  I'm not sure what's the naming convention here, so maybe I'm wrong.
    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    fa380a8 View commit details
    Browse the repository at this point in the history

  2. Use structured suggestions for for_loop_over_fallibles lint

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    d030ba5 View commit details
    Browse the repository at this point in the history

  3. for_loop_over_fallibles: Suggest removing .next()

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    21ec99b View commit details
    Browse the repository at this point in the history

  4. for_loop_over_fallibles: suggest while let loop

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    5dcfdbf View commit details
    Browse the repository at this point in the history

  5. for_loop_over_fallibles: suggest using ? in some cases

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    b2975ee View commit details
    Browse the repository at this point in the history

  6. for_loop_over_fallibles: remove duplication from the message

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    dd842ff View commit details
    Browse the repository at this point in the history

  7. Add a test for the for_loop_over_fallibles lint

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    7308564 View commit details
    Browse the repository at this point in the history

  8. for_loop_over_fallibles: fix suggestion for "remove .next()" case 

    if the iterator is used after the loop, we need to use `.by_ref()`
    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    23a7674 View commit details
    Browse the repository at this point in the history

  9. for_loop_over_fallibles: don't use MachineApplicable 

    The loop could contain `break;` that won't work with an `if let`
    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    8ca57b5 View commit details
    Browse the repository at this point in the history

  10. allow or avoid for loops over option in compiler and tests

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    0250f02 View commit details
    Browse the repository at this point in the history

  11. allow for_loop_over_fallibles in a core test

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    75ae20a View commit details
    Browse the repository at this point in the history

  12. Edit documentation for for_loop_over_fallibles lint

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    b9b2059 View commit details
    Browse the repository at this point in the history

  13. remove an infinite loop

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    6766113 View commit details
    Browse the repository at this point in the history

  14. fix for_loop_over_fallibles lint docs

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    98e0c4d View commit details
    Browse the repository at this point in the history

  15. Fix clippy tests that trigger for_loop_over_fallibles lint

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    9c64bb1 View commit details
    Browse the repository at this point in the history

  16. fixup lint name

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    7434b9f View commit details
    Browse the repository at this point in the history

  17. adopt to new rustc lint api

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    40f36fa View commit details
    Browse the repository at this point in the history

  18. deprecate clippy::for_loops_over_fallibles

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    5347c81 View commit details
    Browse the repository at this point in the history

  19. adopt to building infcx

    @WaffleLapkin
    WaffleLapkin committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    9d4edff View commit details
    Browse the repository at this point in the history