Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #99003

Closed
wants to merge 23 commits into from
Closed

Conversation

Dylan-DPC
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Berend-Jan Lange and others added 23 commits May 23, 2022 20:50
for linux and android
Decrease the Ns of bug loops to a smaller N, which
makes them a lot faster in miri.
In this case, it seems fine to have the field be the inverse of the
flag, especially the `enable` vs `disable` terminology is clear.
Cache DWARF objects alongside object files in work products when those
exist so that DWARF object files are available for thorin in packed mode
in incremental scenarios.

Signed-off-by: David Wood <david.wood@huawei.com>
Compiling with `-Csplit-debuginfo=packed` was leaving behind `.dwo`
files because either the metadata or allocator module contained a DWARF
object which was not being removed by the
`maybe_remove_temps_from_module` closure.
This should have been here from the start... oops. When `thorin` fails
to package a DWARF package, that should fail compilation.
There was a problem with storing a `Box<T>` in a struct, where
the current rules would invalidate the value. this makes it store
a raw pointer instead, circumventing the aliasing problems.
to be able to set a marker/id on the socket for network filtering
 (iptables/ipfw here) purpose.
…2383)

Examples: NON_ASCII_IDENTS, UNCOMMON_CODEPOINTS, CONFUSABLE_IDENTS, MIXED_SCRIPT_CONFUSABLES
Add setter and getter for TCP_QUICKACK on TcpStream for Linux

Reference issue rust-lang#96256

Setting TCP_QUICKACK on TcpStream for Linux
socket `set_mark` addition.

to be able to set a marker/id on the socket for network filtering
 (iptables/ipfw here) purpose.
…n, r=Icnr

Fix ProjectionElem validation

`TypeChecker::visit_projection_elem` was not actually being called.
…iser

Improve soundness of rustc_arena

Make it runnable in miri by changing the loop iteration count for some tests in miri. Also fix a stacked borrows issue with box.
…n-magic, r=wesleywiser

Finishing touches for `#[expect]` (RFC 2383)

This PR adds documentation and some functionality to rustc's lint passes, to manually fulfill expectations. This is needed for some lints in Clippy. Hopefully, it should be one of the last things before we can move forward with stabilizing this feature.

As part of this PR, I've also updated `clippy::duplicate_mod` to showcase how this new functionality can be used and to ensure that it works correctly.

---

changelog: [`duplicate_mod`]: Fixed lint attribute interaction

r? ``@wesleywiser``

cc: rust-lang#97660, rust-lang#85549

And I guess that's it. Here have a magical unicorn 🦄
rustdoc: Cleanup more FIXMEs

r? ``@GuillaumeGomez``
…uct, r=michaelwoerister

incr: cache dwarf objects in work products

Cache DWARF objects alongside object files in work products when those exist so that DWARF object files are available for thorin in packed mode in incremental scenarios.

r? `@michaelwoerister`
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jul 7, 2022
@Dylan-DPC
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Jul 7, 2022

📌 Commit 05ba538 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 7, 2022
@bors
Copy link
Contributor

bors commented Jul 7, 2022

⌛ Testing commit 05ba538 with merge c0aa781578fbfbcf9c9172f4a1ecc993c260b705...

@bors
Copy link
Contributor

bors commented Jul 7, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 7, 2022
@rust-log-analyzer
Copy link
Collaborator

The job dist-i686-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] addr2line test:false 0.283
[RUSTC-TIMING] object test:false 3.706
[RUSTC-TIMING] profiler_builtins test:false 0.063
 Documenting std v0.0.0 (D:\a\rust\rust\library\std)
error[E0433]: failed to resolve: could not find `net` in `os`
 --> library\std\src\os\linux\net.rs:4:20
4 | pub use crate::os::net::tcp::TcpStreamExt;
4 | pub use crate::os::net::tcp::TcpStreamExt;
  |                    ^^^ could not find `net` in `os`
error: Compilation failed, aborting rustdoc

For more information about this error, try `rustc --explain E0433`.
error: could not document `std`
error: could not document `std`

Caused by:
  process didn't exit successfully: `D:\a\rust\rust\build\bootstrap\debug\rustdoc --edition=2021 --crate-type dylib --crate-type rlib --crate-name std library\std\src\lib.rs --target i686-pc-windows-gnu -o D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\doc --cfg "feature=\"addr2line\"" --cfg "feature=\"backtrace\"" --cfg "feature=\"compiler-builtins-c\"" --cfg "feature=\"gimli-symbolize\"" --cfg "feature=\"miniz_oxide\"" --cfg "feature=\"object\"" --cfg "feature=\"panic_unwind\"" --cfg "feature=\"profiler\"" --cfg "feature=\"profiler_builtins\"" --cfg "feature=\"std_detect_dlsym_getauxval\"" --cfg "feature=\"std_detect_file_io\"" -Zunstable-options --check-cfg names() --check-cfg values() --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --markdown-css rust.css --markdown-no-toc -Z unstable-options --resource-suffix 1.64.0 --index-page D:\a\rust\rust\src/doc/index.md -C metadata=6c1b470c4bede152 -L dependency=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps -L dependency=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\release\deps --extern addr2line=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps\libaddr2line-594fec4d51b0b267.rmeta --extern alloc=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps\liballoc-19fa346acc627035.rmeta --extern cfg_if=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps\libcfg_if-dc384c2a17a3fbd8.rmeta --extern compiler_builtins=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps\libcompiler_builtins-b6e10ab61bd3801c.rmeta --extern core=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps\libcore-41f06fd370234f23.rmeta --extern hashbrown=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps\libhashbrown-a0a7d08c5c3d547c.rmeta --extern libc=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps\liblibc-56b8fafe8128deb4.rmeta --extern miniz_oxide=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps\libminiz_oxide-7bef568653016075.rmeta --extern object=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps\libobject-9ab165de41ae458d.rmeta --extern panic_abort=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps\libpanic_abort-e615193541792926.rmeta --extern panic_unwind=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps\libpanic_unwind-c43ecbaca335500a.rmeta --extern profiler_builtins=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps\libprofiler_builtins-348f65607f133031.rmeta --extern rustc_demangle=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps\librustc_demangle-eb19b6d776d6c0f2.rmeta --extern std_detect=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps\libstd_detect-7b3690ba09650e6c.rmeta --extern unwind=D:\a\rust\rust\build\i686-pc-windows-gnu\stage2-std\i686-pc-windows-gnu\release\deps\libunwind-6a58564812617f7d.rmeta -Csymbol-mangling-version=legacy -Zunstable-options -Zunstable-options --check-cfg=values(bootstrap) --check-cfg=values(stdarch_intel_sde) --check-cfg=values(no_fp_fmt_parse) --check-cfg=values(no_global_oom_handling) --check-cfg=values(freebsd12) --check-cfg=values(backtrace_in_libstd) "--check-cfg=values(target_env,\"libnx\")" "--check-cfg=values(target_os,\"watchos\")" "--check-cfg=values(target_arch,\"asmjs\",\"spirv\",\"nvptx\",\"nvptx64\",\"le32\",\"xtensa\")" --check-cfg=values(dont_compile_me) -Dwarnings -Wrustdoc::invalid_codeblock_attributes --crate-version "1.64.0-nightly
  (c0aa78157
  2022-07-07)" "-Zcrate-attr=doc(html_root_url=\"https://doc.rust-lang.org/nightly/\")" --cfg backtrace_in_libstd` (exit code: 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants