fix interpreter validity check on Box #98847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
rustbot
added
the
T-compiler
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
RalfJung
force-pushed
the
box-is-special
branch
2 times, most recently
from
105267f
to
bd3c1c0
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
box-is-special
branch
2 times, most recently
from
6044e6e
to
1cc336c
Compare
This was referenced Jul 4, 2022
|
@bors r+ |
|
📌 Commit d7edf66 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 4, 2022
fix interpreter validity check on Box Follow-up to rust-lang#98554: avoid walking over parts of the value twice. And then move all that logic into the general visitor so not each visitor implementation has to deal with it...
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 4, 2022
fix interpreter validity check on Box Follow-up to rust-lang#98554: avoid walking over parts of the value twice. And then move all that logic into the general visitor so not each visitor implementation has to deal with it...
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 4, 2022
fix interpreter validity check on Box Follow-up to rust-lang#98554: avoid walking over parts of the value twice. And then move all that logic into the general visitor so not each visitor implementation has to deal with it...
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 5, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#97300 (Implement `FusedIterator` for `std::net::[Into]Incoming`) - rust-lang#98761 (more `need_type_info` improvements) - rust-lang#98811 (Interpret: AllocRange Debug impl, and use it more consistently) - rust-lang#98847 (fix interpreter validity check on Box) - rust-lang#98854 (clean up the borrowing in rustc_hir_pretty) - rust-lang#98873 (Suggest `#[derive(Default)]` to enums with `#[default]`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Jul 5, 2022
handle Box with allocators This is the Miri side of rust-lang/rust#98847. Thanks `@DrMeepster` for doing most of the work of getting this test case to pass in Miri. :)
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Jul 5, 2022
handle Box with allocators This is the Miri side of rust-lang/rust#98847. Thanks `@DrMeepster` for doing most of the work of getting this test case to pass in Miri. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #98554: avoid walking over parts of the value twice.
And then move all that logic into the general visitor so not each visitor implementation has to deal with it...