Use liballoc's specialised in-place vec collection #97870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
liballoc already specialises in-place vector collection, so manually reimplementing it in `IdFunctor::try_map_id` was superfluous.
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit 9208c08 with merge 72423f087b612b625133cd04348ee1bc3d887e43... |
|
☀️ Try build successful - checks-actions |
|
Queued 72423f087b612b625133cd04348ee1bc3d887e43 with parent 7425fb2, future comparison URL. |
|
Finished benchmarking commit (72423f087b612b625133cd04348ee1bc3d887e43): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Footnotes |
rustbot
added
perf-regression
|
Well that's surprising... I'll delve into this over the weekend. |
wesleywiser
added
S-waiting-on-author
|
cachegrind diffs of the relevant regressed benchmarks follow beneath. In each case there has been a significant increase in calls to Primary benchmarks Benchmark | Profile | Scenario | % Change | Significance
| | | | Factor
|
|
All I can imagine here is that some |
It should be since we benchmark try builds on perf.rlo. |
|
Ping from triage: |
|
@JohnCSimon thanks for the ping. Honestly, I don't understand the perf regression... I wrote the original code without then appreciating there was a simpler/safer API in stdlib, so this PR was intended just to be a simplifying refactor with no change to behaviour. That it has such a marked perf impact is very strange. If it's unmergeable without the regression being understood/resolved, then I may need some pointers how to proceed? Otherwise I'm happy to close the PR. |
|
One difference is that the std version isn't |
|
Let's try another perf run, because those keccak and cranelift-codegen results could just be noise. @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit 9208c08 with merge 1b3e7d3fffb286f60775006c81d2c91b2af9cf5d... |
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (1b3e7d3fffb286f60775006c81d2c91b2af9cf5d): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
rustbot
added
S-waiting-on-review
|
This now looks fine from a performance POV. |
wesleywiser
approved these changes
Nov 19, 2022
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (becc24a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
liballoc already specialises in-place vector collection, so manually
reimplementing it in
IdFunctor::try_map_idwas superfluous.