Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove confusing sentence from Mutex docs #97821

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Remove confusing sentence from Mutex docs #97821

merged 2 commits into from
Jun 7, 2022

Conversation

Noratrieb
Copy link
Member

The docs were saying something about "statically initializing" the
mutex, and it's not clear what this means. Remove that part to avoid
confusion.

@Noratrieb
Remove confusing sentence from Mutex docs
83af085 
The docs were saying something about "statically initializing" the
mutex, and it's not clear what this means. Remove that part to avoid
confusion.
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 7, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 7, 2022

📌 Commit 83af085 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2022
@Dylan-DPC @wwylele
Update library/std/src/sync/mutex.rs
e224185 
Co-authored-by: Weiyi Wang <wwylele@gmail.com>
@Noratrieb
Copy link
Member Author

I think you have to approve that again @Dylan-DPC

@JohnTitor
Copy link
Member

@bors r+ rollup

@Dylan-DPC Make sure to re-r+ when making another commit.

@bors
Copy link
Contributor

bors commented Jun 7, 2022

📌 Commit e224185 has been approved by JohnTitor

@JohnTitor
Copy link
Member

@bors r=Dylan-DPC

@bors
Copy link
Contributor

bors commented Jun 7, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Jun 7, 2022

📌 Commit e224185 has been approved by Dylan-DPC

@Dylan-DPC
Copy link
Member

yeah thanks for catching it :P was supposed to and then forgot :D

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 7, 2022
@Dylan-DPC
Rollup merge of rust-lang#97821 - Nilstrieb:mutex-docs, r=Dylan-DPC
ff1a2f6 
Remove confusing sentence from `Mutex` docs

The docs were saying something about "statically initializing" the
mutex, and it's not clear what this means. Remove that part to avoid
confusion.
This was referenced Jun 7, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 7, 2022
@bors
Auto merge of rust-lang#97835 - Dylan-DPC:rollup-0ae3pwp, r=Dylan-DPC
5435ed6 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#95948 (Improve the safety docs for `CStr`)
 - rust-lang#97325 (Fix precise field capture of univariant enums)
 - rust-lang#97817 (:arrow_up: rust-analyzer)
 - rust-lang#97821 (Remove confusing sentence from `Mutex` docs)
 - rust-lang#97826 (Add more information for rustdoc-gui tests)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f12605b into rust-lang:master Jun 7, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 7, 2022
@Noratrieb Noratrieb deleted the mutex-docs branch June 8, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwylele wwylele wwylele left review comments

Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Noratrieb @rust-highfive @Dylan-DPC @bors @JohnTitor @wwylele @thomcc @rustbot