Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize Ipv6Addr::to_ipv4_mapped #96906

Merged
merged 2 commits into from
May 23, 2022
Merged

Stabilize Ipv6Addr::to_ipv4_mapped #96906

merged 2 commits into from
May 23, 2022

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented May 10, 2022

CC #27709 (tracking issue for the ip feature which contains more
functions)

The function Ipv6Addr::to_ipv4 is bad because it also returns an IPv4
address for the IPv6 loopback address ::1. Stabilize
Ipv6Addr::to_ipv4_mapped so we can recommend that function instead.

tbu- added 2 commits May 10, 2022 18:06
@tbu-
Stabilize Ipv6Addr::to_ipv4_mapped
839d97e 
CC rust-lang#27709 (tracking issue for the `ip` feature which contains more
functions)

The function `Ipv6Addr::to_ipv4` is bad because it also returns an IPv4
address for the IPv6 loopback address `::1`. Stabilize
`Ipv6Addr::to_ipv4_mapped` so we can recommend that function instead.
@tbu-
Recommend Ipv6Addr::to_ipv4_mapped over Ipv6Addr::to_ipv4
813c5b0 
Fixes rust-lang#96718.
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 10, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2022
@tbu-
Copy link
Contributor Author

tbu- commented May 10, 2022

r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 10, 2022
@rust-highfive rust-highfive assigned dtolnay and unassigned kennytm May 10, 2022
@rustbot rustbot removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 10, 2022
@tbu- tbu- changed the title Stabilize Ipv6Addr::to_ipv4_mapped Stabilize Ipv6Addr::to_ipv4_mapped May 10, 2022
@dtolnay
Copy link
Member

dtolnay commented May 10, 2022

@rust-lang/libs-api:
@rfcbot fcp merge

https://doc.rust-lang.org/std/net/struct.Ipv6Addr.html#method.to_ipv4_mapped

@rfcbot
Copy link

rfcbot commented May 10, 2022 •
edited by BurntSushi
Loading

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels May 10, 2022
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels May 18, 2022
@rfcbot
Copy link

rfcbot commented May 18, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@dtolnay
Copy link
Member

dtolnay commented May 22, 2022

@bors r+

@bors
Copy link
Contributor

bors commented May 22, 2022

📌 Commit 813c5b0 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2022
@bors
Copy link
Contributor

bors commented May 23, 2022

⌛ Testing commit 813c5b0 with merge d125574...

@bors
Copy link
Contributor

bors commented May 23, 2022

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing d125574 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 23, 2022
@bors bors merged commit d125574 into rust-lang:master May 23, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 23, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d125574): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 0 1 2 1
mean2 N/A N/A -3.2% -1.9% -3.2%
max N/A N/A -3.2% -2.0% -3.2%

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: no relevant changes found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 1 0 1 0 2
mean2 2.4% N/A -1.6% N/A 0.4%
max 2.4% N/A -1.6% N/A 2.4%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩ ↩2

  2. the arithmetic mean of the percent change ↩ ↩2

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels May 28, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jun 9, 2022
@JohnTitor JohnTitor added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 21, 2022
@dtolnay dtolnay mentioned this pull request Sep 28, 2023
Open
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klensy klensy klensy left review comments

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.