Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't subst an AdtDef with its own substs #96882

Merged
merged 1 commit into from
May 10, 2022
Merged

Don't subst an AdtDef with its own substs #96882

merged 1 commit into from
May 10, 2022

Conversation

jackh726
Copy link
Member

@jackh726 jackh726 commented May 9, 2022

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 9, 2022
@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2022
@jackh726 jackh726 mentioned this pull request May 9, 2022
Merged
@oli-obk
Copy link
Contributor

oli-obk commented May 9, 2022

r? @oli-obk

@bors r+ rollup

I wish we could detect some of these without false alarms... I've def done similar things before

@bors
Copy link
Contributor

bors commented May 9, 2022

📌 Commit cb1c0c6 has been approved by oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned lcnr May 9, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2022
@JohnTitor JohnTitor mentioned this pull request May 10, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2022
@bors
Auto merge of rust-lang#96904 - JohnTitor:rollup-f1sz5x0, r=JohnTitor
d4c3643 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#96717 (Handle mismatched generic param kinds in trait impls betterly)
 - rust-lang#96725 (Expose process windows_process_extensions_main_thread_handle on Windows)
 - rust-lang#96849 (Move some tests to more reasonable places)
 - rust-lang#96861 (Use Rust 2021 prelude in std itself.)
 - rust-lang#96879 (rustdoc: search result ranking fix)
 - rust-lang#96882 (Don't subst an AdtDef with its own substs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c5f2c44 into rust-lang:master May 10, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 10, 2022
@jackh726 jackh726 deleted the no-subst branch May 10, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jackh726 @rust-highfive @oli-obk @bors @lcnr @rustbot