Suggest replacing typeof(...) with an actual type
#95784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit suggests replacing typeof(...) with an actual type of "...",
for example in case of `typeof(1)` we suggest replacing it with `i32`.
If the expression
- Is not const (`{ let a = 1; let _: typeof(a); }`)
- Can't be found (`let _: typeof(this_variable_does_not_exist)`)
- Or has non-suggestable type (closure, generator, error, etc)
we don't suggest anything.
rustbot
added
the
T-compiler
|
r? @fee1-dead (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| @@ -2462,8 +2462,16 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o { | |||
| self.normalize_ty(ast_ty.span, array_ty) | |||
| } | |||
| hir::TyKind::Typeof(ref e) => { | |||
| tcx.sess.emit_err(TypeofReservedKeywordUsed { span: ast_ty.span }); | |||
| tcx.type_of(tcx.hir().local_def_id(e.hir_id)) | |||
| let ty = tcx.type_of(tcx.hir().local_def_id(e.hir_id)); | |||
There was a problem hiding this comment.
does this report a cycle error if we do something like:
fn foo() -> typeof(foo) {}There was a problem hiding this comment.
hrm.. wonder if that's ez to fix... probably not. should be ok, since this is illegal syntax anyways.
There was a problem hiding this comment.
Does this ICE? If then it should be fixed. Not necessarily in this PR though.
There was a problem hiding this comment.
It doesn't ICE, it just shows the usual cycle error like "cycle detected when computing function signature of foo"
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=c657d61f3db8f63bce43cffa68c1f85b
This comment has been minimized.
This comment has been minimized.
|
this suggestion is relatively harmless, and we already have the infrastructure to suggest it (since we parse the inside of typeof as an AnonConst)... @bors delegate+ |
|
✌️ @WaffleLapkin can now approve this pull request |
|
@bors r+ rollup |
|
📌 Commit 8412d5d has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 10, 2022
…, r=compiler-errors
Suggest replacing `typeof(...)` with an actual type
This PR adds suggestion to replace `typeof(...)` with an actual type of `...`, for example in case of `typeof(1)` we suggest replacing it with `i32`.
If the expression
1. Is not const (`{ let a = 1; let _: typeof(a); }`)
2. Can't be found (`let _: typeof(this_variable_does_not_exist)`)
3. Or has non-suggestable type (closure, generator, error, etc)
we don't suggest anything.
The 1 one is sad, but it's not clear how to support non-consts expressions for `typeof`.
_This PR is inspired by [this tweet]._
[this tweet]: https://twitter.com/compiler_errors/status/1511945354752638976
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#95566 (Avoid duplication of doc comments in `std::char` constants and functions) - rust-lang#95784 (Suggest replacing `typeof(...)` with an actual type) - rust-lang#95807 (Suggest adding a local for vector to fix borrowck errors) - rust-lang#95849 (Check for git submodules in non-git source tree.) - rust-lang#95852 (Fix missing space in lossy provenance cast lint) - rust-lang#95857 (Allow multiple derefs to be splitted in deref_separator) - rust-lang#95868 (rustdoc: Reduce allocations in a `html::markdown` function) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds suggestion to replace
typeof(...)with an actual type of..., for example in case oftypeof(1)we suggest replacing it withi32.If the expression
{ let a = 1; let _: typeof(a); })let _: typeof(this_variable_does_not_exist))we don't suggest anything.
The 1 one is sad, but it's not clear how to support non-consts expressions for
typeof.This PR is inspired by this tweet.