Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow self-profiler to only record potentially costly arguments when argument recording is turned on #95689

Merged
merged 6 commits into from
Apr 16, 2022
Merged

Allow self-profiler to only record potentially costly arguments when argument recording is turned on #95689

merged 6 commits into from
Apr 16, 2022

Commits on Apr 7, 2022

  1. turn exec comment into doc comment

    @lqd
    lqd committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    1c4ae7a View commit details
    Browse the repository at this point in the history

  2. add generic_activity_with_arg_recorder to the self-profiler 

    This allows profiling costly arguments to be recorded only when `-Zself-profile-events=args` is on: using a closure that takes an `EventArgRecorder` and call its `record_arg` or `record_args` methods.
    @lqd
    lqd committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    7585269 View commit details
    Browse the repository at this point in the history

  3. simplify a self-profiling activity call in the LLVM backend 

    and so that it doesn't allocate unless event argument recording is turned on
    @lqd
    lqd committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    3a80067 View commit details
    Browse the repository at this point in the history

  4. simplify a self-profiling activity call in the cg_gcc backend

    @lqd
    lqd committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    af22801 View commit details
    Browse the repository at this point in the history

  5. remove allocation from a self-profiling call in the LLVM backend

    @lqd
    lqd committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    b6a7b5a View commit details
    Browse the repository at this point in the history

  6. port codegen_module activity to arg recorder API

    @lqd
    lqd committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    1906b7e View commit details
    Browse the repository at this point in the history