Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how src/tools/x searches for python #95443

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Clarify how src/tools/x searches for python #95443

merged 1 commit into from
Mar 30, 2022

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Mar 29, 2022

Before, it confusingly looked like python was chosen last instead of first.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 29, 2022
@jyn514 jyn514 mentioned this pull request Mar 29, 2022
Merged
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 30, 2022

📌 Commit f5fb293 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 30, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 30, 2022
@bors
Auto merge of rust-lang#95466 - Dylan-DPC:rollup-g7ddr8y, r=Dylan-DPC
05142a7 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#95294 (Document Linux kernel handoff in std::io::copy and std::fs::copy)
 - rust-lang#95443 (Clarify how `src/tools/x` searches for python)
 - rust-lang#95452 (fix since field version for termination stabilization)
 - rust-lang#95460 (Spellchecking compiler code)
 - rust-lang#95461 (Spellchecking some comments)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 33730c8 into rust-lang:master Mar 30, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 30, 2022
@jyn514 jyn514 deleted the clarify-python-search-logic branch February 25, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jyn514 @rust-highfive @Dylan-DPC @bors @Mark-Simulacrum @rustbot