Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell users that || operators are not currently supported in let chain expressions #95314

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Mar 25, 2022

Tells that || operators are not currently supported instead of not allowed. See #53667 (comment)

In other words, this PR is pretty much trivial.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 25, 2022
@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 25, 2022
@lcnr
Copy link
Contributor

lcnr commented Mar 28, 2022

can you update the pr description + title? after that r=me, thanks

@bors delegate+

@bors
Copy link
Contributor

bors commented Mar 28, 2022

✌️ @c410-f3r can now approve this pull request

@c410-f3r c410-f3r changed the title Minor let_chains modifications Tell users that || operators are not currently supported in let chain expressions Mar 28, 2022
@c410-f3r
Copy link
Contributor Author

@lcnr Modifications were carried out as asked

@bors r=lcnr

@bors
Copy link
Contributor

bors commented Mar 28, 2022

📌 Commit 9e0b7c3 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#95301 (Remove `Nonterminal::NtTT`.)
 - rust-lang#95314 (Tell users that `||` operators are not currently supported in let chain expressions)
 - rust-lang#95350 (resolve: Simplify some diagnostic code to avoid an ICE)
 - rust-lang#95370 ([bootstrap] Don't print `Suite not skipped` unless `--verbose` is set)
 - rust-lang#95390 (Ignore doc comments in a declarative macro matcher.)
 - rust-lang#95401 (Remove duplicated and unused test files)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4651c8d into rust-lang:master Mar 28, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants