Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promot debug_assert to assert #94712

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

kckeiks
Copy link
Contributor

@kckeiks kckeiks commented Mar 7, 2022

Fixes #94705

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 7, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 7, 2022

📌 Commit 776be7e has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 8, 2022
…sumption, r=Mark-Simulacrum

promot debug_assert to assert

Fixes rust-lang#94705
@RalfJung
Copy link
Member

RalfJung commented Mar 8, 2022

Fixes #94705

I guess the question is if that is the only case in libstd where we made this assumption (about POSIX error lists being exhaustive)? It was just the first one I found, that's why it ended up in the issue.

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 8, 2022
…sumption, r=Mark-Simulacrum

promot debug_assert to assert

Fixes rust-lang#94705
@kckeiks
Copy link
Contributor Author

kckeiks commented Mar 8, 2022

Fixes #94705

I guess the question is if that is the only case in libstd where we made this assumption (about POSIX error lists being exhaustive)? It was just the first one I found, that's why it ended up in the issue.

I went by what @cuviper said about treating these on a case by case basis but maybe I misunderstood. I'd gladly take a look to see if there are more and create a PR?

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 8, 2022
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#91993 (Tweak output for non-exhaustive `match` expression)
 - rust-lang#92385 (Add Result::{ok, err, and, or, unwrap_or} as const)
 - rust-lang#94559 (Remove argument from closure in thread::Scope::spawn.)
 - rust-lang#94580 (Emit `unused_attributes` if a level attr only has a reason)
 - rust-lang#94586 (Generalize `get_nullable_type` to allow types where null is all-ones.)
 - rust-lang#94708 (diagnostics: only talk about `Cargo.toml` if running under Cargo)
 - rust-lang#94712 (promot debug_assert to assert)
 - rust-lang#94726 (:arrow_up: rust-analyzer)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a077e44 into rust-lang:master Mar 8, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdlib makes assumptions about errors returned by POSIX functions
6 participants