Rollup of 9 pull requests #94314
Merged
Rollup of 9 pull requests #94314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust previously encoded the `char` type as DW_ATE_unsigned_char. The more appropriate encoding is DW_ATE_UTF. Clang uses this same debug encoding for char32_t. This fixes the display of `char` types in Windows debuggers as well as LLDB.
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
Change `char` type in debuginfo to DW_ATE_UTF Rust previously encoded the `char` type as DW_ATE_unsigned_char. The more appropriate encoding is `DW_ATE_UTF`. Clang also uses the DW_ATE_UTF for `char32_t` in C++. This fixes the display of the `char` type in the Windows debuggers. Without this change, the variable did not show in the locals window.  LLDB 13 is also able to display the char value, when before it failed with `need to add support for DW_TAG_base_type 'char' encoded with DW_ATE = 0x8, bit_size = 32` r? `@wesleywiser`
…elwoerister Remove unused ordering derivations and bounds for `SimplifiedTypeGen` This is another small PR clearing the way for work on rust-lang#90317.
Miri: relax fn ptr check As discussed in rust-lang/unsafe-code-guidelines#72 (comment), the function pointer check done by Miri is currently overeager: contrary to our usual principle of only checking rather uncontroversial validity invariants, we actually check that the pointer points to a real function. So, this relaxes the check to what the validity invariant probably will be (and what the reference already says it is): the function pointer must be non-null, and that's it. The check that CTFE does on the final value of a constant is unchanged -- CTFE recurses through references, so it makes some sense to also recurse through function pointers. We might still want to relax this in the future, but that would be a separate change. r? `@oli-obk`
…lett add matching doc to errorkind Rework of rust-lang#90706
…lan-DPC remove feature gate in control_flow examples Stabilization was done in rust-lang#91091, but the two examples weren't updated accordingly. Probably too late to put it into stable, but it should be in the next release :)
Cleanup a few Decoder methods This is just some simple follow up to rust-lang#93839. r? `@nnethercote`
…atomics, r=petrochenkov riscv32imc_esp_espidf: set max_atomic_width to 64 For espidf targets without native atomics, there is atomic emulation inside [the newlib component of espidf](https://github.com/espressif/esp-idf/blob/master/components/newlib/stdatomic.c), this has been extended to support emulation up to 64bits therefore we are safe to increase the atomic width for the `riscv32imc_esp_espidf` target. Closes esp-rs#107 cc: `@ivmarkov`
…=lnicola ⬆️ rust-analyzer r? `@ghost`
Fix a typo in documentation of `array::IntoIter::new_unchecked` 🌸
rustbot
added
T-compiler
|
@bors r+ rollup=never p=9 |
|
📌 Commit bdcdd1b has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Feb 24, 2022
Tested on commit rust-lang/rust@1204400. Direct link to PR: <rust-lang/rust#94314> 💔 miri on windows: test-pass → test-fail (cc @eddyb @RalfJung @oli-obk). 💔 miri on linux: test-pass → test-fail (cc @eddyb @RalfJung @oli-obk).
This was referenced Feb 24, 2022
|
Finished benchmarking commit (1204400): comparison url. Summary: This benchmark run shows 4 relevant improvements 🎉 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
chartype in debuginfo to DW_ATE_UTF #89887 (Changechartype in debuginfo to DW_ATE_UTF)SimplifiedTypeGen#94267 (Remove unused ordering derivations and bounds forSimplifiedTypeGen)array::IntoIter::new_unchecked#94300 (Fix a typo in documentation ofarray::IntoIter::new_unchecked)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup