Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interner cleanups #93147

Merged
merged 2 commits into from
Jan 22, 2022
Merged

Interner cleanups #93147

merged 2 commits into from
Jan 22, 2022

Commits on Jan 20, 2022

  1. Make stability interning follow the usual pattern.

    @nnethercote
    nnethercote committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    c55819a View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Clarify some code relating to interning and types. 

    I have found this code very confusing at times. This commit clarifies
things.

In particular, the commit explains the requirements that the `Borrow`
impls put on the `Eq` and `Hash` impls, which are non-obvious. And it
puts the `Borrow` impls first, since they force `Eq` and `Hash` to have
particular forms.

The commit also notes `TyS`'s uniqueness requirements.
    @nnethercote
    nnethercote committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    d46ed5d View commit details
    Browse the repository at this point in the history