ast: Always keep a NodeId in ast::Crate
#92575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
This makes it more uniform with other expanded nodes
petrochenkov
force-pushed
the
cratenodeid
branch
from
789bdc3
to
55595c5
Compare
|
@bors r+ |
|
📌 Commit 55595c5 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 5, 2022
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#92092 (Drop guards in slice sorting derive src pointers from &mut T, which is invalidated by interior mutation in comparison) - rust-lang#92388 (Fix a minor mistake in `String::try_reserve_exact` examples) - rust-lang#92442 (Add negative `impl` for `Ord`, `PartialOrd` on `LocalDefId`) - rust-lang#92483 (Stabilize `result_cloned` and `result_copied`) - rust-lang#92574 (Add RISC-V detection macro and more architecture instructions) - rust-lang#92575 (ast: Always keep a `NodeId` in `ast::Crate`) - rust-lang#92583 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more uniform with other expanded nodes.
It makes generic code in #92573 simpler in particular.
This is another follow-up to #91313.
r? @Aaron1011