Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore flaky panic-short-backtrace-windows-x86_64.rs test for now #92498

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

camelid
Copy link
Member

@camelid camelid commented Jan 2, 2022

Mitigates (but does not fix) #92000.

It has been causing a lot of spurious test failures recently that slow
down the bors queue.

@camelid camelid added A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows O-windows-msvc Toolchain: MSVC, Operating system: Windows labels Jan 2, 2022
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 2, 2022
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 2, 2022
@Mark-Simulacrum
Copy link
Member

r=me with ignore-test as the "canonical" way to disable a test like this.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2022
It has been causing a lot of spurious test failures recently that slow
down the bors queue.
@camelid
Copy link
Member Author

camelid commented Jan 5, 2022

Ah, that's what it's called, thanks!

@bors r=Mark-Simulacrum rollup

@bors
Copy link
Contributor

bors commented Jan 5, 2022

📌 Commit 0286ae4 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 5, 2022
@camelid
Copy link
Member Author

camelid commented Jan 5, 2022

@bors rollup=maybe p=1 (fixes frequent CI problem)

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2022
…imulacrum

Ignore flaky `panic-short-backtrace-windows-x86_64.rs` test for now

Mitigates (but does not fix) rust-lang#92000.

It has been causing a lot of spurious test failures recently that slow
down the bors queue.
@bors
Copy link
Contributor

bors commented Jan 5, 2022

⌛ Testing commit 0286ae4 with merge b03c504...

@bors
Copy link
Contributor

bors commented Jan 5, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing b03c504 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 5, 2022
@bors bors merged commit b03c504 into rust-lang:master Jan 5, 2022
@rustbot rustbot added this to the 1.59.0 milestone Jan 5, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b03c504): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@camelid camelid deleted the ignore-flaky-test branch January 5, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. O-windows Operating system: Windows O-windows-msvc Toolchain: MSVC, Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants