Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #89047

Merged
merged 24 commits into from
Sep 17, 2021
Merged

Commits on Sep 12, 2021

  1. Configuration menu
    Copy the full SHA
    ab83d50 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Configuration menu
    Copy the full SHA
    2a2bfd1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    21b7052 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Add chown functions to std::os::unix::fs to change the owner and grou…

    …p of files
    
    This is a straightforward wrapper that uses the existing helpers for C
    string handling and errno handling.
    
    Having this available is convenient for UNIX utility programs written in
    Rust, and avoids having to call unsafe functions like `libc::chown`
    directly and handle errors manually, in a program that may otherwise be
    entirely safe code.
    
    In addition, these functions provide a more Rustic interface by
    accepting appropriate traits and using `None` rather than `-1`.
    joshtriplett committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    4840f67 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    862d89e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    11c0e58 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. delay error for enabling unstable lib features

    If #![feature] is used outside the nightly channel for only lib
    features, the check will be delayed to the stability pass after
    parsing. This is done so that appropriate help messages can be shown if
    the #![feature] has been used needlessly
    vishadGoyal authored and Mark-Simulacrum committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    9f7e281 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. Configuration menu
    Copy the full SHA
    58765d6 View commit details
    Browse the repository at this point in the history
  2. Use multipart_suggestion

    JohnTitor committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    e9bf73c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9342be5 View commit details
    Browse the repository at this point in the history
  4. Apply review comments

    JohnTitor committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    ee99bb3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bc49c3b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    57ee7a6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cd3f4da View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#86422 - JohnTitor:clearer-parens-err-for-lo…

    …op, r=estebank
    
    Emit clearer diagnostics for parens around `for` loop heads
    
    Fixes rust-lang#63113
    r? `@estebank`
    GuillaumeGomez committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    b6d0cca View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#87460 - FabianWolff:issue-87456, r=Aaron1011

    Point to closure when emitting 'cannot move out' for captured variable
    
    Attempts to fix rust-lang#87456. The error message now points to the capturing closure, but I was not able to explain _why_ the closure implements `Fn` or `FnMut` (`TypeckResults::closure_kind_origins` did not contain anything for the closure in question).
    
    cc `@Aaron1011`
    GuillaumeGomez committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    aed7f00 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#87566 - JohnTitor:find-eqeq-on-assoc-type-b…

    …ounds, r=estebank
    
    Recover invalid assoc type bounds using `==`
    
    Fix rust-lang#87493
    r? `@estebank`
    GuillaumeGomez committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    1b78967 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#88666 - GuillaumeGomez:compiler-docs, r=Mar…

    …k-Simulacrum
    
    Improve build command for compiler docs
    
    It was rather complicated to document rustc crates. With this, you can directly run:
    
    ```console
    x.py doc compiler
    x.py doc compiler/rustc_hir_pretty
    ```
    
    The second commit adds the handling of the `--open` flag.
    
    r? `@Mark-Simulacrum`
    GuillaumeGomez committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    765f153 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#88899 - FabianWolff:issue-88844, r=matthewj…

    …asper
    
    Do not issue E0071 if a type error has already been reported
    
    Fixes rust-lang#88844. A suggested fix is already included in the error message for E0412, so with my changes, E0071 is simply not emitted anymore if the type in question is a "type error". This makes sense, I think, because we cannot confidently state that something is "not a struct" if we couldn't resolve it properly; and it's unnecessary to pollute the output with this additional error message, as it is a direct consequence of the former error.
    
    I have also addressed the issue mentioned in rust-lang#88844 (comment) by changing the fixed example in the documentation to more closely match the erroneous code example.
    GuillaumeGomez committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    307f2dd View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#88949 - FabianWolff:issue-87563, r=estebank

    Fix handling of `hir::GenericArg::Infer` in `wrong_number_of_generic_args.rs`
    
    Fixes rust-lang#87563. More precisely, I have fixed the "index out of bounds" error, which is what rust-lang#87563 is about. The example given there still ICEs due to running into this `todo!()`, but I'd say that this is a separate issue:
    https://github.com/rust-lang/rust/blob/c3c0f80d6081092faff801542dd82f0e2420152b/compiler/rustc_typeck/src/astconv/mod.rs#L460-L463
    GuillaumeGomez committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    6f5c098 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#88953 - joshtriplett:chown, r=dtolnay

    Add chown functions to std::os::unix::fs to change the owner and group of files
    
    This is a straightforward wrapper that uses the existing helpers for C
    string handling and errno handling.
    
    Having this available is convenient for UNIX utility programs written in
    Rust, and avoids having to call unsafe functions like `libc::chown`
    directly and handle errors manually, in a program that may otherwise be
    entirely safe code.
    
    In addition, these functions provide a more Rustic interface by
    accepting appropriate traits and using `None` rather than `-1`.
    GuillaumeGomez committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    723d279 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#88954 - nbdd0121:panic3, r=oli-obk

    Allow `panic!("{}", computed_str)` in const fn.
    
    Special-case `panic!("{}", arg)` and translate it to `panic_display(&arg)`. `panic_display` will behave like `panic_any` in cosnt eval and behave like `panic!(format_args!("{}", arg))` in runtime.
    
    This should bring Rust 2015 and 2021 to feature parity in terms of `const_panic`; and hopefully would unblock the stabilisation of rust-lang#51999.
    
    `@rustbot` modify labels: +T-compiler +T-libs +A-const-eval +A-const-fn
    
    r? `@oli-obk`
    GuillaumeGomez committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    eb62779 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#88964 - GuillaumeGomez:version-help, r=Nemo157

    Add rustdoc version into the help popup
    
    After a discussion with a rustdoc user about a specific behaviour, we realized we were not talking about the same version. To add on top of it, it was actually not that simple to find out the version since it was hosted documentation.
    
    So to simplify things, I added the version into the help popup:
    
    ![Screenshot from 2021-09-16 10-45-52](https://user-images.githubusercontent.com/3050060/133581128-b93b460a-e1cb-4a31-9f2f-97c7a916cfcc.png)
    
    Does the version format looks or would you prefer that I add more information? We can also add the commit hash, commit date, host and release.
    
    cc `@rust-lang/rustdoc`
    r? `@jyn514`
    GuillaumeGomez committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    833358b View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#89012 - vishadGoyal:issue-88802-fix, r=jyn514

    Suggest removing `#![feature]` for library features that have been stabilized
    
    Issue: rust-lang#88802
    Delayed the check if #![feature] has been used to enable lib features in a non-nightly build to occur after TyCtxt has been constructed.
    GuillaumeGomez committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    101a88f View commit details
    Browse the repository at this point in the history