Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mark if_let_guard as an incomplete feature #87937

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Don't mark if_let_guard as an incomplete feature #87937

merged 1 commit into from
Aug 25, 2021

Conversation

LeSeulArtichaut
Copy link
Contributor

I don't think there is any reason for if_let_guard to be an incomplete feature, and I think the reason they were marked in the first place was simply because they weren't implemented at all.

r? @pnkfelix
cc tracking issue #51114

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 11, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@LeSeulArtichaut LeSeulArtichaut mentioned this pull request Aug 15, 2021
Merged
@bors

This comment has been minimized.

Sign in to view
@nagisa
Copy link
Member

nagisa commented Aug 23, 2021

Having two feature gates for what seems to be a feature with no very obvious flaws seems quite excessive indeed. Just one is sufficient to signal potential issues that could remain.

r? @nagisa
@bors r+

@bors
Copy link
Contributor

bors commented Aug 23, 2021

📌 Commit dabdd6d has been approved by nagisa

@rust-highfive rust-highfive assigned nagisa and unassigned pnkfelix Aug 23, 2021
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2021
@LeSeulArtichaut LeSeulArtichaut mentioned this pull request Aug 25, 2021
Open
8 tasks
@bors
Copy link
Contributor

bors commented Aug 25, 2021

⌛ Testing commit dabdd6d with merge a992a11...

@bors
Copy link
Contributor

bors commented Aug 25, 2021

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing a992a11 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 25, 2021
@bors bors merged commit a992a11 into rust-lang:master Aug 25, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 25, 2021
@LeSeulArtichaut LeSeulArtichaut deleted the active-if-let-guards branch August 25, 2021 18:03
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 26, 2021
@bors
Auto merge of rust-lang#88066 - LeSeulArtichaut:patterns-cleanups, r=…
76e755c 
…nagisa

Use if-let guards in the codebase and various other pattern cleanups

Dogfooding if-let guards as experimentation for the feature.

Tracking issue rust-lang#51114. Conflicts with rust-lang#87937.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nagisa nagisa

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.
7 participants
@LeSeulArtichaut @rust-log-analyzer @bors @nagisa @pnkfelix @rust-highfive @rustbot